-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more ZnDraw-features #4972
Comments
Here is a one-line change to make the complete CI/CD pipeline happy: diff --git a/testsuite/scripts/importlib_wrapper.py b/testsuite/scripts/importlib_wrapper.py
index f3dd8e5b44..5bc879338c 100644
--- a/testsuite/scripts/importlib_wrapper.py
+++ b/testsuite/scripts/importlib_wrapper.py
@@ -396,3 +396,3 @@ class GetEspressomdVisualizerImports(ast.NodeVisitor):
def __init__(self):
- self.visualizers = {"visualization"}
+ self.visualizers = {"visualization", "zn"}
self.namespace_visualizers = { |
|
@jngrad Regarding the cookie issue, are you sure that you have enable all cookies? On firefox for example I worked fine when using |
I did not try all options, but the two specifically mentioned were not resolving the issue. I gave up and allowed everything. |
After updating to ZnDraw 0.4.6, I can no longer start a ZnDraw server on Chrome and Firefox:
pip freeze
|
What. I tested in on some of the most common browsers. Chrome, Firefox, Edge, Brave all worked with no issues at all. The internal ZnDraw tests for starting a server also passed. Is the problem you are facing simply using the Visualizer as provided by the PR, or your work on making it run on binder? |
I used your PR on the |
We created a new user account to get a fresh Firefox/Chrome/JupyterLab installation, and your PR now works. |
Partial fix for #4972 Description of changes: - Remove unnecessary socket-call in the update loop - Allow multiple instances of the visualizer in the same notebook - Have only one server run in the background when initializing the first `Visualizer`-instance - Center the camera on initialization - Clip wall shape at the box boundaries - Expose the `self.zndraw`-object for direct manipulation of `ZnDraw` - Bump to 'ZnDraw 0.4.6'
len(zndraw)
call in update loop to avoid socket-callAllow non-Jupyter usepostponed due to unsolved runaway server problemsAsynchronous Server startupAdd color gradients for particle colors depending on the distance to referencelama
, ZnDraw creates a white rectangle in Jupyter instead of displaying the GUI (works fine in Chrome, on Firefox one can still click on the server URL to open the visualizer in a new tab and see everything)Find out ifnot possibledatamodel-code-generator
can be made a soft dependency (it has a lot of dependencies)ext_forces
The text was updated successfully, but these errors were encountered: