-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build system improvements #4608
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify conditionals and generator expressions. Rewrite FindMpiexecBackend as a regular function. Make found package messages more homogeneous.
The generator no longer silently ignores invalid CMake external features and invalid myconfig features when the compiler fails to parse either cmake_config.hpp or myconfig.hpp. The complicated double inclusion mechanism for cmake_config.hpp was replaced by a regular include statement, since the check_myconfig target already ensures that no external features are defined in myconfig.hpp. The generator is now unit tested.
Remove unused external features. Rename incorrect valgrind feature. Check that external features defined in the features.def always match those defined in cmake_config.cmakein.
jngrad
force-pushed
the
cmake_maintenance
branch
from
November 22, 2022 17:39
1595aac
to
3ca3962
Compare
reinaual
previously approved these changes
Nov 24, 2022
reinaual
approved these changes
Nov 25, 2022
stekajack
added a commit
to stekajack/espresso_patched
that referenced
this pull request
Dec 12, 2022
Description of changes: - use modern CMake and enable ccache for CUDA files - document all CMake options of the ESPResSo project - fix regressions in the python documentation that will become errors in future Sphinx and autopep versions - rewrite and unit test the config file generator - bugfix: compiler errors are no longer ignored when parsing `myconfig-final.hpp` and `cmake_config.hpp` - bugfix: external features mismatch between `features.def` and `cmake_config.cmakein` now throws errors
jngrad
pushed a commit
to jngrad/espresso
that referenced
this pull request
Dec 23, 2022
Description of changes: - use modern CMake and enable ccache for CUDA files - document all CMake options of the ESPResSo project - fix regressions in the python documentation that will become errors in future Sphinx and autopep versions
jngrad
pushed a commit
to jngrad/espresso
that referenced
this pull request
Dec 23, 2022
Description of changes: - use modern CMake and enable ccache for CUDA files - document all CMake options of the ESPResSo project - fix regressions in the python documentation that will become errors in future Sphinx and autopep versions
jngrad
pushed a commit
to jngrad/espresso
that referenced
this pull request
Dec 23, 2022
Description of changes: - use modern CMake and enable ccache for CUDA files - document all CMake options of the ESPResSo project - fix regressions in the python documentation that will become errors in future Sphinx and autopep versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
myconfig-final.hpp
andcmake_config.hpp
features.def
andcmake_config.cmakein
now throws errors