Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build system improvements #4608

Merged
merged 9 commits into from
Nov 25, 2022
Merged

Conversation

jngrad
Copy link
Member

@jngrad jngrad commented Nov 22, 2022

Description of changes:

  • use modern CMake and enable ccache for CUDA files
  • document all CMake options of the ESPResSo project
  • fix regressions in the python documentation that will become errors in future Sphinx and autopep versions
  • rewrite and unit test the config file generator
    • bugfix: compiler errors are no longer ignored when parsing myconfig-final.hpp and cmake_config.hpp
    • bugfix: external features mismatch between features.def and cmake_config.cmakein now throws errors

@jngrad jngrad marked this pull request as ready for review November 22, 2022 10:35
@jngrad jngrad requested a review from reinaual November 22, 2022 10:35
The generator no longer silently ignores invalid CMake external
features and invalid myconfig features when the compiler fails
to parse either cmake_config.hpp or myconfig.hpp. The complicated
double inclusion mechanism for cmake_config.hpp was replaced by a
regular include statement, since the check_myconfig target already
ensures that no external features are defined in myconfig.hpp.
The generator is now unit tested.
Remove unused external features. Rename incorrect valgrind feature.
Check that external features defined in the features.def always
match those defined in cmake_config.cmakein.
reinaual
reinaual previously approved these changes Nov 24, 2022
@jngrad jngrad requested a review from reinaual November 24, 2022 13:54
@jngrad jngrad added the automerge Merge with kodiak label Nov 25, 2022
@kodiakhq kodiakhq bot merged commit e1d0e49 into espressomd:python Nov 25, 2022
@jngrad jngrad deleted the cmake_maintenance branch November 25, 2022 13:02
stekajack added a commit to stekajack/espresso_patched that referenced this pull request Dec 12, 2022
Description of changes:
- use modern CMake and enable ccache for CUDA files
- document all CMake options of the ESPResSo project
- fix regressions in the python documentation that will become errors in future Sphinx and autopep versions
- rewrite and unit test the config file generator
   - bugfix: compiler errors are no longer ignored when parsing `myconfig-final.hpp` and `cmake_config.hpp`
   - bugfix: external features mismatch between `features.def` and `cmake_config.cmakein` now throws errors
jngrad pushed a commit to jngrad/espresso that referenced this pull request Dec 23, 2022
Description of changes:
- use modern CMake and enable ccache for CUDA files
- document all CMake options of the ESPResSo project
- fix regressions in the python documentation that will become errors in future Sphinx and autopep versions
jngrad pushed a commit to jngrad/espresso that referenced this pull request Dec 23, 2022
Description of changes:
- use modern CMake and enable ccache for CUDA files
- document all CMake options of the ESPResSo project
- fix regressions in the python documentation that will become errors in future Sphinx and autopep versions
jngrad pushed a commit to jngrad/espresso that referenced this pull request Dec 23, 2022
Description of changes:
- use modern CMake and enable ccache for CUDA files
- document all CMake options of the ESPResSo project
- fix regressions in the python documentation that will become errors in future Sphinx and autopep versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants