Fix operator transformation from body frame to lab frame #4683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bug in convert_body_to_space().
jngrad
changed the title
| @@ -189,6 +189,38 @@ BOOST_AUTO_TEST_CASE(propagate_omega_quat_particle_test) { | |||
| } | |||
| } | |||
|
|
|||
| BOOST_AUTO_TEST_CASE(convert_operator_body_to_space_test) { | |||
| auto constexpr sqrt_2_half = Utils::sqrt_2() / 2.0; | |||
| // rotation around z-axis by pi/2 | |||
There was a problem hiding this comment.
sorry that I am late but what does rotation around z-axis mean here?
I do not get the test
There was a problem hiding this comment.
It's a typo in the comment. The quaternion actually describes a rotation around the y-axis. This can be fixed as part of the 4.2.1 release spellcheck or as part of the fix for #4667. The idea behind this test is to make sure the old behavior is not re-introduced by mistake. As I understood it , the behavior in ticket #4667 is actually caused by two bugs: the rotation matrix was incorrectly applied (the particle quaternion describes the rotation from the z-axis to the director, so we need to revert the direction) and the prefactor was not transformed.
jngrad
pushed a commit
to jngrad/espresso
that referenced
this pull request
Mar 21, 2023
…4683) Partially fixes espressomd#4667 Description of changes: - Fix operator transformation - Add unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #4667
Description of changes: