Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix particle anisotropy in thermostats #4690

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

christophlohrmann
Copy link
Contributor

Fixes #4667

Description of changes:

  • Apply body-to-space-transformation to noise term

Notes:

  • We need the same level of testing also for the rotational thermostats
  • The whole friction-and-noise force-calculation should be abstracted so it can be used by LB aswell

@jngrad jngrad force-pushed the fix_partcl_aniso branch from c2de260 to 0cac82e Compare March 20, 2023 14:03
Copy link
Member

@jngrad jngrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jngrad jngrad added this to the Espresso 4.2.1 milestone Mar 20, 2023
@kodiakhq kodiakhq bot merged commit 62d1479 into espressomd:python Mar 20, 2023
jngrad pushed a commit to jngrad/espresso that referenced this pull request Mar 21, 2023
Fixes espressomd#4667 

Description of changes:
- Apply body-to-space-transformation to noise term

Notes: 
- We need the same level of testing also for the rotational thermostats
- The whole friction-and-noise force-calculation should be abstracted so it can be used by LB aswell
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Langevin thermostat with anisotropic friction is broken
2 participants