messages: add option to not show the first unread message

[bobrippling]

For example, if a user wants to keep them unread and just scroll through what's arrived

[gfwilliams]

I think it's expected that the default for settings.showMsgIfUnread should be 1? It is in settings? But then in the messagegui app it's not set so the default is 0, so any user upgrading will suddenly not have the latest message shown.

It might make more sense to rename it to settings.ignoreUnread/similar so then you can simply check it with !! and we don't have to have defaults in all the files?

[bobrippling]

I think it's expected that the default for settings.showMsgIfUnread should be 1? It is in settings?

It is indeed:

BangleApps/apps/messages/settings.js

Line 14 in f5b3ad2

if (settings.showMsgIfUnread === undefined) settings.showMsgIfUnread = 1;

But then in the messagegui app it's not set so the default is 0, so any user upgrading will suddenly not have the latest message shown.

Yes - there are other settings which are defaulted in messages but not in messagegui, so a new user will also experience issues too:

BangleApps/apps/messages/settings.js

Lines 6 to 13 in ebd2d5b

	if (settings.vibrate===undefined) settings.vibrate=":";
	if (settings.vibrateCalls===undefined) settings.vibrateCalls=":";
	if (settings.repeat===undefined) settings.repeat=4;
	if (settings.repeatCalls===undefined) settings.repeatCalls=settings.repeat;
	if (settings.vibrateTimeout===undefined) settings.vibrateTimeout=60;
	if (settings.unreadTimeout===undefined) settings.unreadTimeout=60;
	if (settings.maxMessages===undefined) settings.maxMessages=3;
	if (settings.iconColorMode === undefined) settings.iconColorMode = iconColorModes[0];

It might make more sense to rename it to settings.ignoreUnread/similar so then you can simply check it with !! and we don't have to have defaults in all the files?

Sure - although considering the above, do we perhaps want to either duplicate/share the defaulting to fix messages for new users, or would you be happy with the rename?

[gfwilliams]

I think just rename for now.

It's a bit of a pain because we use the same settings file for several different apps, so for instance maxMessages is only used in the widget, but we do:

let settings = Object.assign({flash: true, maxMessages: 3}, require("Storage").readJSON("messages.settings.json", true) || {});

I just checked and as far as I can see all those things you mention actually do have defaults that are handled ok, they're just not done in a very nice way often (eg vibrateCalls/etc). I guess it might be nice to use the Object.assign pattern above at some point and clean the code up, but I think for now we're good

[bobrippling]

Thanks - rename done, ready for a re-review

[gfwilliams]

Thanks! Looks good to me! I'm happy to merge whenever you are.

One strange thing is the use of settings().stuff in the settings app which causes settings to be loaded multiple times just to show one menu. That was there already though :)

[bobrippling]

Thanks - yeah that's a fair point, shall merge this first though