Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spacer: Compare GPS with Baido and Glonass #3674

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

pavelmachek
Copy link
Contributor

No description provided.

@bobrippling
Copy link
Collaborator

Looks cool - will give it a text next I'm outside

@pavelmachek
Copy link
Contributor Author

I must admit I did development in the meantime. Now it has satellite view, too, touch bottom part of screen to switch between views. And you'll still sometimes get "undefined", due to races, but it should demonstrate the idea. Unfortunately hw does not report separate pdop (etc) values, even when there's space in the protocol for that, so you'll have to switch systems to play with that (top left corner).

GPS fix is usual here, but I was able to get Beidou fix, too. Yay!

@bobrippling
Copy link
Collaborator

Cool, nice additions! There's just the undefined issue above and I notice if a user has the dark theme set then they can't see what's going on in the app - some colour values would need altering for it to work (e.g. using g.theme.fg, etc)

@pavelmachek
Copy link
Contributor Author

U replaced undefined with (no data). For themes, that would be more work, and looking at code... there's more work to be done on the code. Could I get you to apply this and do theme fixes in the next version (along with other cleanups)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants