add SDCard support for ESP32

[MaBecker]

by removing FLASHFS

[MaBecker]

added pr #1779

[gfwilliams]

FlashFS was there for a reason (to provide easy access to on-chip flash). I'm not sure it should just be removed?

@wilberforce was the one that added it AFAIK.

[MaBecker]

Just checked, ESP32 is the one and only that is using FlashFS.

FlashFS was there for a reason (to provide easy access to on-chip flash). I'm not sure it should just be removed?

Can you please lookup the download stat for ESP32.

Personally I am a big fan of the Storage lib and try to avoid SDCards where ever it is possible.

There are only very little section added as flash 8k and 64k

Espruino/targets/esp32/jshardware.c

Lines 733 to 742 in e568c6c

	JsVar *jshFlashGetFree() {
	JsVar *jsFreeFlash = jsvNewEmptyArray();
	if (!jsFreeFlash) return 0;
	// Space reserved here in the parition table - using sub type 0x40
	// This should be read from the partition table
	addFlashArea(jsFreeFlash, 0xE000, 0x2000);
	addFlashArea(jsFreeFlash, 0x2B0000, 0x10000);
	return jsFreeFlash;
	}

Ups 0x2B0000 has to be changed to 0x310000

[MaBecker]

just added #1781

[wilberforce]

I don't understand why removing this is an improvement to the ESP32 implementation.

All chips have 4MB or more of memory, and 1Mb had been reserved at work as FlashFS.

Why would you remove this to use an external SD card that only some of the boards have?

Worst case - make it switchable to use either - I just don't see what the benefit is here?

[MaBecker]

Thanks for your input. Will check if both can be used.

[gfwilliams]

Another option is now Storage is better, to extend the flash area used for that and remove FlashFS.

[MaBecker]

Using both at the same time cause a undefined reference to sdSPISetup

libs/filesystem/jswrap_file.o:(.literal.jswrap_file_kill+0x0): undefined reference to `sdSPISetup'
libs/filesystem/jswrap_file.o: In function `jswrap_file_kill':
/Espruino/repos/MaBecker/libs/filesystem/jswrap_file.c:214: undefined reference to `sdSPISetup'
libs/filesystem/jswrap_file.o: In function `jswrap_E_connectSDCard':
/Espruino/repos/MaBecker/libs/filesystem/jswrap_file.c:155: undefined reference to `sdSPISetup'
collect2: error: ld returned 1 exit status

[MaBecker]

Not sure how to continue.

Fact : Adding FLASHFS has broken SDCard function.

Suggestion: Remove FLASHFS for now and bring it back when someone has fixed the linker issue.

OR: Close this and remove SDCard support form ESP32 docs.

[MaBecker]

Any hints how to handle the conflict named above?

[gfwilliams]

I guess I feel a little like given how much flash there is available, having the filesystem built in is probably more useful than SD card support? I haven't seen too many ESPxx boards with SD cards on? Maybe just the ESP32CAM ones?

I think probably just update the docs to say it's not supported? I don't think you can easily have them coexist since FlashFS uses a 4k block size but SD cards will only want 512

[MaBecker]

So let's close this.