-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose error type #276
feat: expose error type #276
Conversation
@multivoltage thanks for the PR! This looks great. Just a few changes before I can merge:
I appreciate the TypeScript updates! |
Also if you can make sure to follow the Commitlint format for commit messages, that's what's causing tests to fail right now. Thanks!! |
In my local pc seems ok (node 18) |
@multivoltage hmm, you're right. I'm not actually sure what the problem is, but it seems like it may be a problem with the version of |
@nebrelbug I replicated issue. But in you yaml you install before
and then use npx. I think you have 2 possible fix:
Please give me a feedback. Do you plan to fix this in seperate pr? |
@multivoltage I'll fix the commitlint issue in a separate PR later. In the meantime, I'll merge anyways if you can fix the issues I mentioned above. |
@nebrelbug
I thought the same thing inirtially but then I ask my self?
|
ee0a1d4
to
e4e8ebb
Compare
@multivoltage thank you! Having a base |
@multivoltage released in Eta 3.4.0:) |
I tried to export EtaError types introducing new types like @nebrelbug did in THIS issue.
Some point about he PR:
throw
starting from top-level api. For example using.render()
even if the exception is inside.readFile()
never
as return type since for me a function that throw 100% of times an error equals to a function that never run an error (token from TS docs)I don't know if this PR follow exactly the structure described here:
#243 (comment)
But probably this PR can be a starting point and I'm happy to change some part after review