Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop-rails from 2.20.2 to 2.21.0 #1216

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 11, 2023

Bumps rubocop-rails from 2.20.2 to 2.21.0.

Release notes

Sourced from rubocop-rails's releases.

RuboCop Rails 2.21.0

New features

  • #1075: Add new Rails/SelectMap cop that checks for uses of select(:column_name) with map(&:column_name). (@​koic)
  • #158: Add Rails/DangerousColumnNames cop. (@​r7kamura)
  • #1072: Add TransactionMethods config for Rails/TransactionExitStatement to detect custom transaction methods. (@​marocchino)
  • #967: Add new Rails/UnusedRenderContent cop. (@​samrjenkins)
  • #1052: Add explicit style to Rails/I18nLazyLookup. (@​sunny)

Bug fixes

  • #1078: Fix a false negative for Rails/LexicallyScopedActionFilter when no methods are defined. (@​vlad-pisanov)
  • #1060: Fix a false positive for Rails/HttpStatus when using symbolic value that have no numeric value mapping. (@​koic)
  • #1004: Fix a false-positive for Rails/RootPathnameMethods on Ruby 2.4 or lower. (@​r7kamura)
  • #1016: Add Rails/RedundantActiveRecordAllMethod cop. (@​masato-bkn)
  • #1066: Fix an error for Rails/FilePath when string interpolated Rails.root is followed by a message starting with .. (@​koic)
  • #1049: Fix an incorrect autocorrect for Rails/FilePath when File.join with Rails.root and path starting with /. (@​ydah)
  • #1045: Fix an incorrect autocorrect for Rails/NegateInclude when using Style/InverseMethods's autocorrection together. (@​koic)
  • #1062: Fix autocorrection for Rails/RakeEnvironment when rake task accepts arguments. (@​fastjames)
  • #1036: Fix an error for UniqueValidationWithoutIndex when db/schema.rb is empty. (@​fatkodima)
  • #1042: Fix no offences for Rails/SchemaComment when create_table with multi t columns. (@​nipe0324)

Changes

Changelog

Sourced from rubocop-rails's changelog.

2.21.0 (2023-09-09)

New features

  • #1075: Add new Rails/SelectMap cop that checks for uses of select(:column_name) with map(&:column_name). ([@​koic][])
  • #158: Add Rails/DangerousColumnNames cop. ([@​r7kamura][])
  • #1072: Add TransactionMethods config for Rails/TransactionExitStatement to detect custom transaction methods. ([@​marocchino][])
  • #967: Add new Rails/UnusedRenderContent cop. ([@​samrjenkins][])
  • #1052: Add explicit style to Rails/I18nLazyLookup. ([@​sunny][])

Bug fixes

  • #1078: Fix a false negative for Rails/LexicallyScopedActionFilter when no methods are defined. ([@​vlad-pisanov][])
  • #1060: Fix a false positive for Rails/HttpStatus when using symbolic value that have no numeric value mapping. ([@​koic][])
  • #1004: Fix a false-positive for Rails/RootPathnameMethods on Ruby 2.4 or lower. ([@​r7kamura][])
  • #1016: Add Rails/RedundantActiveRecordAllMethod cop. ([@​masato-bkn][])
  • #1066: Fix an error for Rails/FilePath when string interpolated Rails.root is followed by a message starting with .. ([@​koic][])
  • #1049: Fix an incorrect autocorrect for Rails/FilePath when File.join with Rails.root and path starting with /. ([@​ydah][])
  • #1045: Fix an incorrect autocorrect for Rails/NegateInclude when using Style/InverseMethods's autocorrection together. ([@​koic][])
  • #1062: Fix autocorrection for Rails/RakeEnvironment when rake task accepts arguments. ([@​fastjames][])
  • #1036: Fix an error for UniqueValidationWithoutIndex when db/schema.rb is empty. ([@​fatkodima][])
  • #1042: Fix no offences for Rails/SchemaComment when create_table with multi t columns. ([@​nipe0324][])

Changes

  • #1056: Fix database adapter detection for nested config. ([@​mjankowski][])
  • #1031: Make Lint/SafeNavigationChain allow presence_in. ([@​koic][])
  • #1080: Make Rails/HttpStatus aware of string number status. ([@​r7kamura][])
  • #1094: Make Rails/TimeZone aware of String#to_time. ([@​koic][])
  • #1015: Make Style/InvertibleUnlessCondition aware of Active Support methods. ([@​koic][])
  • #903: Read database config for Rails/BulkChangeTable from environment variable. ([@​joergschiller][])
  • #1058: Relax Include path for Rails/FindBy and Rails/FindEach. ([@​koic][])
  • #994: Restrict DuplicateAssociation cop to ActiveRecord. ([@​mjankowski][])
Commits
  • 1e8df6f Cut 2.21.0
  • dfa9ccc Update Changelog
  • e465675 Merge pull request #970 from samrjenkins/add-unused-render-content-cop
  • 8555ac5 [Fix #967] Add new Rails/UnusedRenderContent cop
  • 1bcba4d Merge pull request #1102 from koic/add_new_rails_select_map_cop
  • 38e408a Merge pull request #903 from joergschiller/database_from_env_bulk_change_table
  • bda5de3 Read database config from environment variable
  • baf39e6 Merge pull request #1101 from koic/make_rails_http_status_aware_of_string_num...
  • 8cfb90f Merge pull request #1103 from rubocop/dependabot/github_actions/actions/check...
  • 522ab6d Bump actions/checkout from 3 to 4
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Sep 11, 2023
Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails) from 2.20.2 to 2.21.0.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases)
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop-rails@v2.20.2...v2.21.0)

---
updated-dependencies:
- dependency-name: rubocop-rails
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@Un3x Un3x force-pushed the dependabot/bundler/rubocop-rails-2.21.0 branch from cd395d3 to ffd3f1b Compare September 11, 2023 09:34
@Un3x
Copy link
Contributor

Un3x commented Sep 11, 2023

@Samuelfaure J'veux bien une relecture / validation sur celle là. Vu qu'il y a eu des ajouts de policies et que ca fonctionne pas nécessairement.

Typiquement les 2 règles que j'ai désactivé présente des défauts :

@Un3x Un3x force-pushed the dependabot/bundler/rubocop-rails-2.21.0 branch from ffd3f1b to 7ed629e Compare September 11, 2023 09:41
@Samuelfaure
Copy link
Contributor

OK pour moi, question de goût mais find_each je trouve ça moche tfaçon

et pour le bug bah tant pis pour le moment

@Samuelfaure Samuelfaure self-requested a review September 11, 2023 10:04
@Un3x Un3x merged commit a9ec108 into develop Sep 11, 2023
5 checks passed
@Un3x Un3x deleted the dependabot/bundler/rubocop-rails-2.21.0 branch September 11, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants