Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UPnP unwanted termination #611

Merged
merged 3 commits into from
Feb 2, 2024
Merged

Fix UPnP unwanted termination #611

merged 3 commits into from
Feb 2, 2024

Conversation

ziogaschr
Copy link
Member

@ziogaschr ziogaschr commented Feb 1, 2024

This pull request fixes the issue where the portMappingLoop function was prematurely terminated, causing the defer function to be called and trigger "Deleting port mapping" 2 minutes after the initial launch. The fix involves changing the return statement to a continue statement in order to continue the loop.

Fixes #609.

Background: this has been introduced with ethereum/go-ethereum#26359. If this PR solves the issue we will make a PR at ethereum/go-ethereum as well.

which was causing the defer function to be called and trigger “Deleting port mapping” 2 minutes after the initial launch
Copy link
Contributor

@diega diega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Astonishing catch!

Copy link
Contributor

@meowsbits meowsbits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😻

@ziogaschr ziogaschr merged commit e56a929 into master Feb 2, 2024
5 of 7 checks passed
@ziogaschr ziogaschr deleted the fix/upnp-loop branch February 2, 2024 12:26
@ziogaschr ziogaschr mentioned this pull request Feb 5, 2024
@meowsbits meowsbits mentioned this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why was UDP closed in the latest update?
3 participants