Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schedule dencun on holesky #94

Merged
merged 2 commits into from
Jan 19, 2024
Merged

schedule dencun on holesky #94

merged 2 commits into from
Jan 19, 2024

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented Dec 21, 2023

@g11tech g11tech mentioned this pull request Dec 21, 2023
Merged
@pk910
Copy link
Member

pk910 commented Dec 22, 2023

I think the cancun timestamp should be added to the EL genesis (genesis.json / besu.json / chainspec.json) too?

"cancunTime": 1701347280

@g11tech
Copy link
Contributor Author

g11tech commented Dec 23, 2023

I think the cancun timestamp should be added to the EL genesis (genesis.json / besu.json / chainspec.json) too?

"cancunTime": 1701347280

Ahh yes this has full custom config, makes sense will update 👍

Geewhiz999
Geewhiz999 reviewed Jan 13, 2024
View reviewed changes
custom_config_data/genesis.json
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

custom_config_data/genesis.json

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

custom_config_data/genesis.json

@rolfyone rolfyone mentioned this pull request Jan 15, 2024
Closed
@tersec tersec merged commit d05bc1c into eth-clients:main Jan 19, 2024
@realbigsean
Copy link
Contributor

this config's missing MAX_PER_EPOCH_ACTIVATION_CHURN_LIMIT: 8

@realbigsean
Copy link
Contributor

made a PR for it here #95

@realbigsean realbigsean mentioned this pull request Jan 19, 2024
Merged
@terencechain terencechain mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Geewhiz999 Geewhiz999 Geewhiz999 approved these changes

@philknows philknows philknows approved these changes

@barnabasbusa barnabasbusa barnabasbusa approved these changes

@parithosh parithosh parithosh approved these changes

@tersec tersec tersec approved these changes

@pk910 pk910 pk910 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@g11tech @pk910 @realbigsean @tersec @parithosh @barnabasbusa @philknows @Geewhiz999