Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove erc777 #359

Closed
wants to merge 2 commits into from
Closed

Conversation

dawksh
Copy link

@dawksh dawksh commented Oct 29, 2023

Recently OpenZeppelin upgraded contracts to v.5.0.0 and above which has removed the ERC777 implementation. Since the AA kit still uses it, it results in conflicts.

ERC777 is an overengineered solution, more about it here

This PR fixes #354 and makes the kit supported out of the box without hassle of changing dependencies.

@dawksh dawksh requested a review from ManuLpz4 November 24, 2023 16:16
@leopoldjoy
Copy link

Hello @dawksh @ManuLpz4, would it be possible to get this fix merged? Thank you!

@dawksh
Copy link
Author

dawksh commented Dec 8, 2023

I'm not sure why the checks are failing @ManuLpz4 any ideas?

@drortirosh
Copy link
Contributor

done as part of #384

@drortirosh drortirosh closed this Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

For newer version of @openzeppelin/contracts@^5.0.0 ERC777 has been removed.
4 participants