You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The type used for POST requests is IWithData<phin.IOptions> but the IWithData is not exported in types.d.ts so there's no way to construct a typed options object without making a custom type.
Also, there's a note in the types about using the generics to make JSON/Form posting mutually exclusive, but wouldn't this work just as well?
Fixesethan7g#63
Exports IWithData and IWithForm types
Explicitly makes generic extend IOptionsBase
Changes IWithData's data property to be string, Buffer, or object (allows strings, Buffers, objects, or arrays)
No behavior is affected so no new tests were written
I kept the generics but explicitly made the T extend IOptionsBase and updated the data property of IWithData to be compatible with what Centra accepts.
The type used for POST requests is
IWithData<phin.IOptions>
but theIWithData
is not exported intypes.d.ts
so there's no way to construct a typed options object without making a custom type.Also, there's a note in the types about using the generics to make JSON/Form posting mutually exclusive, but wouldn't this work just as well?
The text was updated successfully, but these errors were encountered: