Initial draft for EthereumStratum/2.0.0 proposal #1571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
suggested changes
Nov 29, 2018
EIPS/eip-1571.md
Outdated
| --- | ||
| eip: 1571 | ||
| title: EthereumStratum/2.0.0 | ||
| author: Andrea Lanfranchi [@AndreaLanfranchi](https://github.com/AndreaLanfranchi) <[email protected]>, Pawel Bylica [@chfast](https://github.com/chfast) <[email protected]>, Marius Van Der Wijden [@MariusVanDerWijden](https://github.com/MariusVanDerWijden) |
There was a problem hiding this comment.
Change [@AndreaLanfranchi](https://github.com/AndreaLanfranchi) to (@AndreaLanfranchi) for all names.
nicksavers
reviewed
Nov 29, 2018
| - Eventually either party closes session and TCP connection | ||
|
|
||
| ### Session Handling - Hello | ||
| ~~One of the worst annoyances until now is that server, at the very moment of socket connection, does not provide any useful information about the stratum flavour implemented. This means the client has to start a conversation by iteratively trying to connect via different protocol flavours. This proposal amends the situation making mandatory for the server to advertise itself to the client. |
There was a problem hiding this comment.
Does this strikethrough paragraph need to be here?
There was a problem hiding this comment.
No it doesn't. Can be removed
There was a problem hiding this comment.
You can update it with a new pull request and it should be auto-merged now that the Draft is in the repository.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial draft for EthereumStratum/2.0.0 proposal