Add special requirement in EIP-1 for mentioning EVM instructions #1968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
changed the title
|
This is pretty specific, but sure it seems like the obvious thing. Are there any EIP (Draft or Final) that currently don't meet this requirement? |
|
There area lot. At point started to fix them and ended up with a few hundred lines of changes, but never finished it. I can push the branch separately, but wouldn't pollute this PR. |
holgerd77
reviewed
May 1, 2019
|
@nicksavers pushed here a branch (https://github.com/axic/EIPs/tree/eip1-opcodes-updates) which fixes it for many files (but not all). |
|
@nicksavers @Arachnid can we merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.