Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP-1474 as a requirement to RPC ERCs #2058

Merged
merged 1 commit into from
Jun 12, 2019
Merged

Conversation

axic
Copy link
Member

@axic axic commented May 21, 2019

No description provided.

@eip-automerger
Copy link

eip-automerger commented May 21, 2019

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

@axic
Copy link
Member Author

axic commented May 21, 2019

@bitpshr @CJentzsch @charles-cooper @MicahZoltu @tcz001 @sorpaas @tinybike can you please approve?

@axic axic added the ERC label May 21, 2019
@MicahZoltu
Copy link
Contributor

FYI: The markdown for https://eips.ethereum.org/EIPS/eip-1474 is broken at the bottom of the page, at least on Windows Firefox. The little expanding sections of Methods section aren't working properly.

@axic
Copy link
Member Author

axic commented May 21, 2019

@MicahZoltu I know, that is being addressed in #2059.

@axic
Copy link
Member Author

axic commented May 21, 2019

@sorpaas it seems your email is not recognised, do you want to change ERC-695 to use your username?

@charles-cooper
Copy link
Contributor

@axic I'm not really following the purpose of this PR. What does it mean for an EIP to depend on a later EIP?

@axic
Copy link
Member Author

axic commented May 22, 2019

Please have a look at EIP-1474. It specifies the Ethereum JSON-RPC protocol.

Your EIP-1898 extends the Ethereum JSON-RPC protocol, hence it makes sense to refer to the specification being extended/changed.

@axic
Copy link
Member Author

axic commented May 26, 2019

@CJentzsch @simon-jentzsch can you please approve?

@gcolvin gcolvin merged commit 9457546 into ethereum:master Jun 12, 2019
@axic axic deleted the rpc-updates branch June 12, 2019 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants