Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark EIP-695 as Final #2432

Merged
merged 1 commit into from
May 26, 2020
Merged

Mark EIP-695 as Final #2432

merged 1 commit into from
May 26, 2020

Conversation

sorpaas
Copy link
Contributor

@sorpaas sorpaas commented Dec 9, 2019

@eip-automerger
Copy link

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

  • Trying to change EIP 695 state from Last Call to Final

@BelfordZ
Copy link

BelfordZ commented Dec 16, 2019

@sorpaas @whilei could you please include the following API specification?

{ 
   "name": "eth_chainId", 
   "summary": "Returns the currently configured chain id", 
   "description": "Returns the currently configured chain id, a value used in replay-protected transaction signing as introduced by [EIP-155](https://github.com/ethereum/EIPs/blob/master/EIPS/eip-155.md).", 
   "params": [], 
   "result": { 
     "name": "chainId", 
     "description": "hex format integer of the current chain id. Defaults are ETC=61, ETH=1, Morden=62.", 
     "schema": { 
       "title": "chainId", 
       "type": "string", 
       "pattern": "^0x[a-fA-F\\d]+$" 
     } 
   } 
 }

@sorpaas
Copy link
Contributor Author

sorpaas commented May 4, 2020

Ping editors as I got asked that there're other EIPs depending on this.

@axic
Copy link
Member

axic commented May 5, 2020

I think there are still some unsolved comments on the discussion URL.

@rekmarks
Copy link
Contributor

@axic Security considerations section added in: #2642

@rekmarks
Copy link
Contributor

rekmarks commented May 14, 2020

@axic, I believe that all outstanding items have been addressed as of this morning, Pacific Time.

Edit: EIP reference notation was fixed in: #2643

@rekmarks
Copy link
Contributor

@axic, do the editors need anything else from the authors before this can be merged?

@rekmarks
Copy link
Contributor

rekmarks commented May 26, 2020

Summary of Resolved Last Call Issues

In addition, formatting issues were fixed in:

To the best of my knowledge, those are the only issues flagged by editors, or otherwise considered necessary to address by the authors.

cc: @Arachnid

@Arachnid Arachnid merged commit 4cc3816 into ethereum:master May 26, 2020
pizzarob pushed a commit to pizzarob/EIPs that referenced this pull request Jun 12, 2020
tkstanczak pushed a commit to tkstanczak/EIPs that referenced this pull request Nov 7, 2020
Arachnid pushed a commit to Arachnid/EIPs that referenced this pull request Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants