-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
struggling with travis #2662
struggling with travis #2662
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bad automerger!
``` | ||
Error: at pc=0, op=BEGINSUB: invalid subroutine entry | ||
``` | ||
Consumed gas: `26` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gcolvin Why did you revert this? I had updated these testcases
When you say "JUMPSUB be low, and RETURNSUB be verylow" Do you mean JUMPSUB = 5 and RETURNSUB = 3? Because I see that you have changed JUMPSUB but RETURNSUB is equal to 2 on the tests |
This PR made some random changes here and there, but the PR description does not even mention what the intended changes were -- I don't know which ones were intentional and which ones were somehow just accidents during merge :/ |
From the YP:
So jumpsub should be |
That makes sense |
Hi, I'm a bot! This change was automatically merged because: - It only modifies existing Draft or Last Call EIP(s) - The PR was approved or written by at least one author of each modified EIP - The build is passing
Hi, I'm a bot! This change was automatically merged because: - It only modifies existing Draft or Last Call EIP(s) - The PR was approved or written by at least one author of each modified EIP - The build is passing
Hi, I'm a bot! This change was automatically merged because: - It only modifies existing Draft or Last Call EIP(s) - The PR was approved or written by at least one author of each modified EIP - The build is passing
another try at getting this past travis