Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Travis CI to GitHub Actions #5236

Merged
merged 5 commits into from
Jul 13, 2022

Conversation

Pandapip1
Copy link
Member

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@eth-bot
Copy link
Collaborator

eth-bot commented Jul 12, 2022

A critical and unhandled exception has occurred:
Message: not found
Data: (there is no data for this error)(cc @alita-moore, @mryalamanchi)

@Pandapip1
Copy link
Member Author

CC: @MicahZoltu @lightclient

@Pandapip1
Copy link
Member Author

Pandapip1 commented Jul 13, 2022

Note: fixing the typos in the EIP files is essential for the new CI to function. Otherwise, it will fail all new PRs.

Copy link
Contributor

@MicahZoltu MicahZoltu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a fan of moving away from Travis CI and over to GitHub Actions. This appears to be a pretty straight port of the Travis CI configuration to GitHub actions.

What was it that changed in codespell though? I don't see it. Just a newer version of codespell?

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@Pandapip1
Copy link
Member Author

Pandapip1 commented Jul 13, 2022

What was it that changed in codespell though? I don't see it. Just a newer version of codespell?

Codespell used to only run on lines that were changed. However, I can't seem to find a way to do that with GitHub actions, so it's running against the entire repo.

Also, test out what happens if we remove the exceptions for certain EIPs
Copy link
Member

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we're going to test this in prod! :)

@lightclient lightclient merged commit 5c4dc86 into ethereum:master Jul 13, 2022
@Pandapip1 Pandapip1 deleted the migrate-travis-to-gh-actions branch July 19, 2022 15:41
@donBarbos donBarbos mentioned this pull request Sep 20, 2022
nachomazzara pushed a commit to nachomazzara/EIPs that referenced this pull request Jan 13, 2023
* Migrate to Github actions

* Remove master branch restriction

* Fix first round of bugs

* Inline arguments

Also, test out what happens if we remove the exceptions for certain EIPs

* No idea what happened there
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants