Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old EIP-20 file #5302

Merged
merged 2 commits into from
Jul 28, 2022
Merged

Remove old EIP-20 file #5302

merged 2 commits into from
Jul 28, 2022

Conversation

Pandapip1
Copy link
Member

Bye!

@eth-bot
Copy link
Collaborator

eth-bot commented Jul 21, 2022

A critical and unhandled exception has occurred:
Message: not found
Data: (there is no data for this error)(cc @alita-moore, @mryalamanchi)

@Pandapip1
Copy link
Member Author

(I will need either @MicahZoltu or @lightclient to manually merge this once someone else approves)

@MicahZoltu
Copy link
Contributor

We had this here so that people who had links to it would not get a 404. We never decided on an EOL strategy at the time, so it has sat here ever since. It is not clear to me what the right deprecation strategy is here, whether now or sometime in the future.

@Pandapip1
Copy link
Member Author

Why not remove it then, and if people complain we re-add it?

@MicahZoltu
Copy link
Contributor

I'm not against that strategy. It has been quite a while since we renamed this EIP. Would like to hear thoughts from other editors.

@Pandapip1
Copy link
Member Author

Other Editor CC: @lightclient @axic @SamWilsn @gcolvin

@Pandapip1 Pandapip1 mentioned this pull request Jul 26, 2022
Closed
@Pandapip1
Copy link
Member Author

@MicahZoltu everyone was okay with removing this file. Please manually merge.

@MicahZoltu MicahZoltu merged commit a918653 into ethereum:master Jul 28, 2022
@Pandapip1 Pandapip1 deleted the remove-old-eip-20-file branch July 28, 2022 16:03
nachomazzara pushed a commit to nachomazzara/EIPs that referenced this pull request Jan 13, 2023
@Pandapip1 @nachomazzara
Remove old EIP-20 file (ethereum#5302)
1b7c38d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pandapip1 @eth-bot @MicahZoltu