EIP 3540 Addition: EOF1 contracts can only DELEGATECALL EOF1 contracts #6359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As suggested by Paweł Bylica (@chfast) I am proposing this EIP addition.
github-actions
bot
added
c-update
File
|
|
The commit cd1bf3c (as a parent of 05487be) contains errors. |
Added Test Cases
gumb0
reviewed
Jan 22, 2023
As discussed on Discord, no restrictions are being placed on any of the following DELEGATECALLs: - EOF2 -> EOF1 - EOF1 -> EOF2 These are left for future consideration.
27 tasks
chfast
suggested changes
Mar 9, 2023
Co-authored-by: Paweł Bylica <[email protected]>
chfast
added a commit
to ethereum/evmone
that referenced
this pull request
May 16, 2023
The code targeted by DELEGATECALL from an EOF must also be an EOF. This restriction has been added to EIP-3540 in ethereum/EIPs#6359.
chfast
added a commit
to ipsilon/tests
that referenced
this pull request
May 17, 2023
According to EIP-3540 updated by ethereum/EIPs#6359 a DELEGATECALL from EOF to legacy code is disallowed. This updates expectations in the single test case of DELEGATECALL EOF → legacy.
chfast
added a commit
to ethereum/evmone
that referenced
this pull request
May 17, 2023
The code targeted by DELEGATECALL from an EOF must also be an EOF. This restriction has been added to EIP-3540 in ethereum/EIPs#6359.
chfast
added a commit
to ipsilon/tests
that referenced
this pull request
May 18, 2023
According to EIP-3540 updated by ethereum/EIPs#6359 a DELEGATECALL from EOF to legacy code is disallowed. This updates expectations in the single test case of DELEGATECALL EOF → legacy.
chfast
added a commit
to ethereum/evmone
that referenced
this pull request
May 18, 2023
The code targeted by DELEGATECALL from an EOF must also be an EOF. This restriction has been added to EIP-3540 in ethereum/EIPs#6359.
chfast
added a commit
to ipsilon/tests
that referenced
this pull request
May 21, 2023
According to EIP-3540 updated by ethereum/EIPs#6359 a DELEGATECALL from EOF to legacy code is disallowed. This updates expectations in the single test case of DELEGATECALL EOF → legacy.
winsvega
pushed a commit
to ethereum/tests
that referenced
this pull request
May 29, 2023
According to EIP-3540 updated by ethereum/EIPs#6359 a DELEGATECALL from EOF to legacy code is disallowed. This updates expectations in the single test case of DELEGATECALL EOF → legacy.
|
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
|
This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by Paweł Bylica (@chfast) I am proposing this EIP addition.
Full discussion here: https://ethereum-magicians.org/t/evm-object-format-eof/5727/48