Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-4844: Cleanup transaction network payload references #7038

Merged
merged 4 commits into from
May 30, 2023
Merged

Update EIP-4844: Cleanup transaction network payload references #7038

merged 4 commits into from
May 30, 2023

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented May 17, 2023 •
edited
Loading

Followup to

Cleans up network payload references:

  • Flatten blob in network rlp representation rather than a list of field elements
  • removes aggregate proof references
  • reorders the network payload to [tx_payload, blobs, commitments, proofs] rather than current [tx_payload, kzgs, blobs, kzg_proofs]
    i.e. blobs first then commitments and proofs rather than blobs in middle of commitments and proofs
  • improve upon validations for network payload

@g11tech g11tech requested a review from eth-bot as a code owner May 17, 2023 13:51
@github-actions github-actions bot added c-update Modifies an existing proposal s-review This EIP is in Review t-core labels May 17, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented May 17, 2023 •
edited
Loading

✅ All reviewers have approved.

@eth-bot eth-bot added the a-review Waiting on author to review label May 17, 2023
lightclient
lightclient reviewed May 22, 2023
View reviewed changes
EIPS/eip-4844.md Outdated Show resolved Hide resolved
@lightclient lightclient dismissed a stale review via 63ceb3d May 22, 2023 17:47
lightclient
lightclient reviewed May 22, 2023
View reviewed changes
EIPS/eip-4844.md Outdated Show resolved Hide resolved
@jflo jflo mentioned this pull request May 23, 2023
Closed
hwwhww
hwwhww reviewed May 25, 2023
View reviewed changes
EIPS/eip-4844.md Outdated Show resolved Hide resolved
@g11tech g11tech mentioned this pull request May 25, 2023
Closed
jflo
jflo reviewed May 25, 2023
View reviewed changes
EIPS/eip-4844.md Outdated Show resolved Hide resolved
@g11tech g11tech dismissed stale reviews from ghost via e0f0265 May 27, 2023 15:50
@g11tech g11tech force-pushed the fix-4844-tx-network-payload branch from e0f0265 to 3543e2f Compare May 27, 2023 15:54
@onbjerg onbjerg mentioned this pull request May 29, 2023
Closed
@g11tech
Update EIP-4844: Cleanup transaction network payload references
4ffda41 
add blob flattening

4844: nit, opcode -> instruction

apply feedback

apply feedback
@g11tech g11tech force-pushed the fix-4844-tx-network-payload branch from 3543e2f to 4ffda41 Compare May 30, 2023 08:47
@g11tech
Copy link
Contributor Author

g11tech commented May 30, 2023

rebased and resolved conflicts

lightclient
lightclient reviewed May 30, 2023
View reviewed changes
EIPS/eip-4844.md Outdated Show resolved Hide resolved
EIPS/eip-4844.md Outdated Show resolved Hide resolved
EIPS/eip-4844.md Outdated Show resolved Hide resolved
lightclient
lightclient reviewed May 30, 2023
View reviewed changes
EIPS/eip-4844.md Outdated Show resolved Hide resolved
lightclient
lightclient approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for the tennis match. Thank you.

@eth-bot eth-bot enabled auto-merge (squash) May 30, 2023 09:50
eth-bot
eth-bot approved these changes May 30, 2023
View reviewed changes
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 4ad3886 into ethereum:master May 30, 2023
This was referenced May 30, 2023
Closed
Closed
Closed
@g11tech
Copy link
Contributor Author

g11tech commented May 30, 2023

LGTM, sorry for the tennis match. Thank you.

no problem 🙂 , thanks for the edits and feedback ❤️ 🙏

@tersec tersec mentioned this pull request Jun 8, 2023
Closed
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberto-bayardo roberto-bayardo roberto-bayardo left review comments

@hwwhww hwwhww hwwhww left review comments

@jflo jflo jflo left review comments

@eth-bot eth-bot eth-bot approved these changes

@lightclient lightclient lightclient approved these changes

Assignees
No one assigned
Labels
a-review Waiting on author to review c-update Modifies an existing proposal s-review This EIP is in Review t-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@g11tech @eth-bot @jflo @hwwhww @roberto-bayardo @lightclient