-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EIP: Interface Naming Conventions #7182
Conversation
Signed-off-by: Pascal Marco Caversaccio <[email protected]>
Signed-off-by: Pascal Marco Caversaccio <[email protected]>
Co-authored-by: Pandapip1 <[email protected]>
Signed-off-by: Pascal Marco Caversaccio <[email protected]>
Signed-off-by: Pascal Marco Caversaccio <[email protected]>
Signed-off-by: Pascal Marco Caversaccio <[email protected]>
Signed-off-by: Pascal Marco Caversaccio <[email protected]>
Signed-off-by: Pascal Marco Caversaccio <[email protected]>
Signed-off-by: Pascal Marco Caversaccio <[email protected]>
File
|
Signed-off-by: Pascal Marco Caversaccio <[email protected]>
The commit 6f53822 (as a parent of 7101bf7) contains errors. |
Signed-off-by: Pascal Marco Caversaccio <[email protected]>
quickly following up: any feedback @axic, @Pandapip1, @SamWilsn, @xinbenlv or can we get this merged since all tests pass? |
I am closing this pull request because we are in the process of separating EIPs and ERCs into distinct repositories. Unfortunately, as far as we are aware, GitHub does not provide any tools to ease this migration, so every pull request will need to be re-opened manually. As this is a PR to create / modify an ERC, I will kindly ask you to redirect this to the new repository at ethereum/ERCs. We have prepared a guide to help with the process. If there is relevant history here, please link to this PR from the new pull request. On behalf of the EIP Editors, I apologize for this inconvenience. |
@pcaversaccio Sorry it's taken so long to get someone to take a look at this! From a first pass, I would say that this isn't a good fit for an EIP. I'd probably publish this as a standalone style guide. Unless I'm misunderstanding the point? Maybe this is supposed to be a normalization step that compilers perform before generating the ABI and hashing interface ids / function selectors? If this is something that is supposed to be shared by all compilers, (1) I think that needs to be made more clear in the proposal, and (2) wouldn't this introduce a ton of backwards compatibility issues? |
This specification defines a standardised way of naming interface functions, event or custom error definitions, or anything else included in an interface definition that is used as an identifier by compilers in some form.