Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-5169: Fix uncompilable memory in event #7295

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

ColinPlatt
Copy link
Contributor

events should not contain memory keyword

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

events should not contain `memory` keyword
@ColinPlatt ColinPlatt requested a review from eth-bot as a code owner July 7, 2023 10:19
@github-actions github-actions bot added c-update Modifies an existing proposal s-final This EIP is Final t-erc labels Jul 7, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Jul 7, 2023

File EIPS/eip-5169.md

Requires 1 more reviewers from @JamesSmartCell, @weiwu-zhang
Requires 2 more reviewers from @axic, @gcolvin, @lightclient, @Pandapip1, @SamWilsn

@eth-bot eth-bot changed the title Update eip-5169.md Update EIP-5169: Update eip-5169.md Jul 7, 2023
@eth-bot eth-bot added the e-consensus Waiting on editor consensus label Jul 7, 2023
@ColinPlatt ColinPlatt changed the title Update EIP-5169: Update eip-5169.md Update EIP-5169: Fix uncompilable memory in event Jul 7, 2023
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a reasonable correction.

@lightclient lightclient merged commit 231684b into ethereum:master Jul 24, 2023
streamnft-tech pushed a commit to streamnft-tech/EIPs that referenced this pull request Oct 27, 2023
Update eip-5169.md

events should not contain `memory` keyword
RaphaelHardFork pushed a commit to RaphaelHardFork/EIPs that referenced this pull request Jan 30, 2024
Update eip-5169.md

events should not contain `memory` keyword
just-a-node pushed a commit to connext/EIPs that referenced this pull request Feb 17, 2024
Update eip-5169.md

events should not contain `memory` keyword
GAEAlimited pushed a commit to GAEAlimited/EIPs that referenced this pull request Jun 19, 2024
Update eip-5169.md

events should not contain `memory` keyword
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-update Modifies an existing proposal e-consensus Waiting on editor consensus s-final This EIP is Final t-erc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants