-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EIP-5169: Fix uncompilable memory in event #7295
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
events should not contain `memory` keyword
github-actions
bot
added
c-update
Modifies an existing proposal
s-final
This EIP is Final
t-erc
labels
Jul 7, 2023
File
|
ColinPlatt
changed the title
Update EIP-5169: Update eip-5169.md
Update EIP-5169: Fix uncompilable memory in event
Jul 7, 2023
5 tasks
SamWilsn
approved these changes
Jul 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a reasonable correction.
lightclient
approved these changes
Jul 24, 2023
streamnft-tech
pushed a commit
to streamnft-tech/EIPs
that referenced
this pull request
Oct 27, 2023
Update eip-5169.md events should not contain `memory` keyword
RaphaelHardFork
pushed a commit
to RaphaelHardFork/EIPs
that referenced
this pull request
Jan 30, 2024
Update eip-5169.md events should not contain `memory` keyword
just-a-node
pushed a commit
to connext/EIPs
that referenced
this pull request
Feb 17, 2024
Update eip-5169.md events should not contain `memory` keyword
GAEAlimited
pushed a commit
to GAEAlimited/EIPs
that referenced
this pull request
Jun 19, 2024
Update eip-5169.md events should not contain `memory` keyword
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c-update
Modifies an existing proposal
e-consensus
Waiting on editor consensus
s-final
This EIP is Final
t-erc
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
events should not contain
memory
keywordWhen opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: