Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-1559: Clarify who pays gas fees #7423

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

0xScratch
Copy link
Contributor

This PR clarifies the language by replacing the term 'transaction' with 'senders' to explicitly identifies who pays the base and priority fee. Makes the fee payment process more understandable for new readers.

This PR clarifies the language by replacing the term 'transaction' with 'senders' to explicitly identifies who pays the base and priority fee. Makes the fee payment process more understandable for new readers.
@0xScratch 0xScratch requested a review from eth-bot as a code owner July 28, 2023 12:35
@github-actions github-actions bot added c-update Modifies an existing proposal s-final This EIP is Final t-core labels Jul 28, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Jul 28, 2023

File EIPS/eip-1559.md

Requires 1 more reviewers from @abdelhamidbakhta, @AFDudley, @econoar, @i-norden, @mslipper, @vbuterin

@eth-bot eth-bot changed the title Update eip-1559.md Update EIP-1559: Update eip-1559.md Jul 28, 2023
@eth-bot eth-bot added the e-consensus Waiting on editor consensus label Jul 28, 2023
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Jul 28, 2023
Copy link
Member

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is slightly clearer.

@Pandapip1 Pandapip1 changed the title Update EIP-1559: Update eip-1559.md Update EIP-1559: Clarify who pays gas fees Jul 29, 2023
@github-actions
Copy link

The commit 6654548 (as a parent of 981733b) contains errors.
Please inspect the Run Summary for details.

@@ -21,7 +21,7 @@ The algorithm results in the base fee per gas increasing when blocks are above t
The base fee per gas is burned.
Transactions specify the maximum fee per gas they are willing to give to miners to incentivize them to include their transaction (aka: priority fee).
Transactions also specify the maximum fee per gas they are willing to pay total (aka: max fee), which covers both the priority fee and the block's network fee per gas (aka: base fee).
The transaction will always pay the base fee per gas of the block it was included in, and they will pay the priority fee per gas set in the transaction, as long as the combined amount of the two fees doesn't exceed the transaction's maximum fee per gas.
Senders will always pay the base fee per gas of the block their transaction was included in, and they will pay the priority fee per gas set in the transaction, as long as the combined amount of the two fees doesn't exceed the transaction's maximum fee per gas.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Senders will always pay the base fee per gas of the block their transaction was included in, and they will pay the priority fee per gas set in the transaction, as long as the combined amount of the two fees doesn't exceed the transaction's maximum fee per gas.
The sender of the transaction will always pay the base fee per gas of the block their transaction was included in, and they will pay the priority fee per gas set in the transaction, as long as the combined amount of the two fees doesn't exceed the transaction's maximum fee per gas.

@lightclient lightclient merged commit ba6c342 into ethereum:master Oct 4, 2023
@0xScratch 0xScratch deleted the patch-1 branch October 4, 2023 15:10
streamnft-tech pushed a commit to streamnft-tech/EIPs that referenced this pull request Oct 27, 2023
Update eip-1559.md

This PR clarifies the language by replacing the term 'transaction' with 'senders' to explicitly identifies who pays the base and priority fee. Makes the fee payment process more understandable for new readers.
RaphaelHardFork pushed a commit to RaphaelHardFork/EIPs that referenced this pull request Jan 30, 2024
Update eip-1559.md

This PR clarifies the language by replacing the term 'transaction' with 'senders' to explicitly identifies who pays the base and priority fee. Makes the fee payment process more understandable for new readers.
just-a-node pushed a commit to connext/EIPs that referenced this pull request Feb 17, 2024
Update eip-1559.md

This PR clarifies the language by replacing the term 'transaction' with 'senders' to explicitly identifies who pays the base and priority fee. Makes the fee payment process more understandable for new readers.
GAEAlimited pushed a commit to GAEAlimited/EIPs that referenced this pull request Jun 19, 2024
Update eip-1559.md

This PR clarifies the language by replacing the term 'transaction' with 'senders' to explicitly identifies who pays the base and priority fee. Makes the fee payment process more understandable for new readers.
blacksnow2 pushed a commit to blacksnow2/EIPs that referenced this pull request Jul 21, 2024
Update eip-1559.md

This PR clarifies the language by replacing the term 'transaction' with 'senders' to explicitly identifies who pays the base and priority fee. Makes the fee payment process more understandable for new readers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-update Modifies an existing proposal e-consensus Waiting on editor consensus s-final This EIP is Final t-core w-ci Waiting on CI to pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants