-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EIP-1559: Clarify who pays gas fees #7423
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR clarifies the language by replacing the term 'transaction' with 'senders' to explicitly identifies who pays the base and priority fee. Makes the fee payment process more understandable for new readers.
github-actions
bot
added
c-update
Modifies an existing proposal
s-final
This EIP is Final
t-core
labels
Jul 28, 2023
lightclient
approved these changes
Jul 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is slightly clearer.
Pandapip1
approved these changes
Jul 29, 2023
Pandapip1
changed the title
Update EIP-1559: Update eip-1559.md
Update EIP-1559: Clarify who pays gas fees
Jul 29, 2023
The commit 6654548 (as a parent of 981733b) contains errors. |
8 tasks
minimalsm
suggested changes
Oct 4, 2023
@@ -21,7 +21,7 @@ The algorithm results in the base fee per gas increasing when blocks are above t | |||
The base fee per gas is burned. | |||
Transactions specify the maximum fee per gas they are willing to give to miners to incentivize them to include their transaction (aka: priority fee). | |||
Transactions also specify the maximum fee per gas they are willing to pay total (aka: max fee), which covers both the priority fee and the block's network fee per gas (aka: base fee). | |||
The transaction will always pay the base fee per gas of the block it was included in, and they will pay the priority fee per gas set in the transaction, as long as the combined amount of the two fees doesn't exceed the transaction's maximum fee per gas. | |||
Senders will always pay the base fee per gas of the block their transaction was included in, and they will pay the priority fee per gas set in the transaction, as long as the combined amount of the two fees doesn't exceed the transaction's maximum fee per gas. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
Senders will always pay the base fee per gas of the block their transaction was included in, and they will pay the priority fee per gas set in the transaction, as long as the combined amount of the two fees doesn't exceed the transaction's maximum fee per gas. | |
The sender of the transaction will always pay the base fee per gas of the block their transaction was included in, and they will pay the priority fee per gas set in the transaction, as long as the combined amount of the two fees doesn't exceed the transaction's maximum fee per gas. |
g11tech
approved these changes
Oct 4, 2023
streamnft-tech
pushed a commit
to streamnft-tech/EIPs
that referenced
this pull request
Oct 27, 2023
Update eip-1559.md This PR clarifies the language by replacing the term 'transaction' with 'senders' to explicitly identifies who pays the base and priority fee. Makes the fee payment process more understandable for new readers.
RaphaelHardFork
pushed a commit
to RaphaelHardFork/EIPs
that referenced
this pull request
Jan 30, 2024
Update eip-1559.md This PR clarifies the language by replacing the term 'transaction' with 'senders' to explicitly identifies who pays the base and priority fee. Makes the fee payment process more understandable for new readers.
just-a-node
pushed a commit
to connext/EIPs
that referenced
this pull request
Feb 17, 2024
Update eip-1559.md This PR clarifies the language by replacing the term 'transaction' with 'senders' to explicitly identifies who pays the base and priority fee. Makes the fee payment process more understandable for new readers.
GAEAlimited
pushed a commit
to GAEAlimited/EIPs
that referenced
this pull request
Jun 19, 2024
Update eip-1559.md This PR clarifies the language by replacing the term 'transaction' with 'senders' to explicitly identifies who pays the base and priority fee. Makes the fee payment process more understandable for new readers.
blacksnow2
pushed a commit
to blacksnow2/EIPs
that referenced
this pull request
Jul 21, 2024
Update eip-1559.md This PR clarifies the language by replacing the term 'transaction' with 'senders' to explicitly identifies who pays the base and priority fee. Makes the fee payment process more understandable for new readers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c-update
Modifies an existing proposal
e-consensus
Waiting on editor consensus
s-final
This EIP is Final
t-core
w-ci
Waiting on CI to pass
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR clarifies the language by replacing the term 'transaction' with 'senders' to explicitly identifies who pays the base and priority fee. Makes the fee payment process more understandable for new readers.