Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP: Theorem-Carrying-Transaction - TCT #7837

Closed
wants to merge 30 commits into from

Conversation

Billy1900
Copy link

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@Billy1900 Billy1900 requested a review from eth-bot as a code owner October 11, 2023 20:29
@eth-bot
Copy link
Collaborator

eth-bot commented Oct 11, 2023

File EIPS/eip-7534.md

Requires 1 more reviewers from @axic, @g11tech, @gcolvin, @lightclient, @Pandapip1, @SamWilsn

@eth-bot eth-bot changed the title Add EIP: TCT Proposal Update Template: TCT Proposal Oct 11, 2023
@eth-bot eth-bot added the e-consensus Waiting on editor consensus label Oct 11, 2023
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Oct 11, 2023
@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-core t-process and removed w-ci Waiting on CI to pass labels Oct 11, 2023
@Billy1900 Billy1900 changed the title Update Template: TCT Proposal Add EIP: TCT Proposal Oct 11, 2023
eip-draft_TCT_abbrev.md Outdated Show resolved Hide resolved
@eth-bot eth-bot changed the title Add EIP: TCT Proposal Update Template: TCT Proposal Oct 12, 2023
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you move the file, the bot will start complaining. You'll need to fix the errors it reports too.

eip-7534.md Outdated Show resolved Hide resolved
@eth-bot eth-bot added the e-review Waiting on editor to review label Jan 18, 2024
@eth-bot eth-bot changed the title Add EIP: TCT Proposal Add EIP: TCT Jan 18, 2024
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Jan 18, 2024
Copy link

The commit 97abc93 (as a parent of 4d11954) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Jan 18, 2024
@Billy1900 Billy1900 requested a review from SamWilsn January 29, 2024 14:42
@Billy1900 Billy1900 requested a review from g11tech January 29, 2024 15:39
EIPS/eip-7534.md Outdated Show resolved Hide resolved
EIPS/eip-7534.md Outdated Show resolved Hide resolved
EIPS/eip-7534.md Outdated Show resolved Hide resolved
EIPS/eip-7534.md Outdated Show resolved Hide resolved
Technically, code path hash $\mathrm{h}$ will be added into `Transaction` struct so each transaction will carry its own hypothesis hash $\mathrm{h}$.

```go
// Transaction is an Ethereum transaction.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't seem to follow ethereum transaction specification

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mean we modify the Transaction struct which violates the ethereum transaction specification?


## Backwards Compatibility

The primary concern lies in the potential for incompatibility, particularly with regards to the occurrence of a fork. The Theorem-Carrying-Transaction (TCT) system may reject certain transactions that violate the theorem, while the original Ethereum network may accept these transactions. This discrepancy in transaction acceptance could lead to a network fork, resulting in divergent block states. To address this issue, we propose conducting a comprehensive evaluation of TCT's effectiveness and stability by initially deploying it on a testnet such as `Goeril`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if its a new transaction type enabled at some fork i don't understand how it makes it backward incompatible

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, it will be incompatible. That's why we want to use a testnet to test TCT first.

Billy1900 and others added 2 commits January 30, 2024 09:28
@eth-bot eth-bot changed the title Add EIP: TCT Add EIP: Theorem-Carrying-Transaction - TCT Jan 30, 2024
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Mar 16, 2024
Copy link

This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

@github-actions github-actions bot closed this Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-core w-stale Waiting on activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants