Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-5656: fix test in eip-5656 #8233

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

charles-cooper
Copy link
Contributor

@charles-cooper charles-cooper commented Feb 18, 2024

the test accidentally demonstrated the behavior of MCOPY with length=9, instead of length=8.

moved the space to byte 8 for clarity

--

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

the test accidentally demonstrated the behavior of MCOPY with length=9,
instead of length=8.

moved the space to byte ethereum#8 for clarity
@github-actions github-actions bot added c-update Modifies an existing proposal t-core labels Feb 18, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Feb 18, 2024

✅ All reviewers have approved.

@eth-bot eth-bot changed the title fix test in eip-5656 Update EIP-5656: fix test in eip-5656 Feb 18, 2024
@eth-bot eth-bot enabled auto-merge (squash) February 18, 2024 15:50
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 3720fc0 into ethereum:master Feb 18, 2024
19 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-update Modifies an existing proposal t-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants