-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EIP-1153: Move to Final #8333
Conversation
Signed-off-by: Tim Beiko <[email protected]>
✅ All reviewers have approved. |
there's a couple bugs in the mcopy tests that i haven't gotten around to updating, i'm not sure if that's important. (they were fixed in all clients and the state tests) |
@charles-cooper if you can update them, that'd be great! Happy to add it to this PR if you point me to the current version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @timbeiko
Signed-off-by: Tim Beiko <[email protected]>
@charles-cooper I've removed the 5656 status update from this PR given the other EIPs only need a status change. I'll let you open a PR for it separately with the test updates 😄 |
The commit fe8995e (as a parent of 5cd6a03) contains errors. |
72411ca
to
690b5bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):
|
Moves EIPs 1153, 7516 and 7568 to Final.
Edit: will move 5656 to a separate PR due to the test changes required.