Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-1153: Move to Final #8333

Merged
merged 4 commits into from
Mar 29, 2024
Merged

Conversation

timbeiko
Copy link
Contributor

@timbeiko timbeiko commented Mar 19, 2024

Moves EIPs 1153, 7516 and 7568 to Final.

Edit: will move 5656 to a separate PR due to the test changes required.

Signed-off-by: Tim Beiko <[email protected]>
@timbeiko timbeiko requested a review from eth-bot as a code owner March 19, 2024 14:42
@github-actions github-actions bot added c-status Changes a proposal's status s-final This EIP is Final t-core t-meta labels Mar 19, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Mar 19, 2024

✅ All reviewers have approved.

@eth-bot eth-bot added the a-review Waiting on author to review label Mar 19, 2024
@eth-bot eth-bot changed the title Finalize some Dencun EIPs Update EIP-1153: Move to Final Mar 19, 2024
@timbeiko timbeiko changed the title Update EIP-1153: Move to Final Move EIPs 1153, 5656, 7516 and 7568 to Final. Mar 19, 2024
@timbeiko timbeiko mentioned this pull request Mar 19, 2024
12 tasks
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Mar 19, 2024
@eth-bot eth-bot changed the title Move EIPs 1153, 5656, 7516 and 7568 to Final. Update EIP-1153: Move to Final Mar 19, 2024
@charles-cooper
Copy link
Contributor

there's a couple bugs in the mcopy tests that i haven't gotten around to updating, i'm not sure if that's important. (they were fixed in all clients and the state tests)

@timbeiko
Copy link
Contributor Author

@charles-cooper if you can update them, that'd be great! Happy to add it to this PR if you point me to the current version.

Copy link
Contributor

@CarlBeek CarlBeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @timbeiko

Signed-off-by: Tim Beiko <[email protected]>
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Mar 21, 2024
@timbeiko
Copy link
Contributor Author

@charles-cooper I've removed the 5656 status update from this PR given the other EIPs only need a status change. I'll let you open a PR for it separately with the test updates 😄

@charles-cooper
Copy link
Contributor

https://github.com/ethereumjs/ethereumjs-monorepo/blob/5d522f731f6bee1b8626a3558fa8c5d5c0f6ebbd/packages/evm/test/eips/eip-5656.spec.ts#L43-L44 have corrected tests i think

Copy link

The commit fe8995e (as a parent of 5cd6a03) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Mar 21, 2024
@lightclient lightclient reopened this Mar 29, 2024
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Mar 29, 2024
@eth-bot eth-bot enabled auto-merge (squash) March 29, 2024 20:48
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 0904d24 into ethereum:master Mar 29, 2024
10 checks passed
@eip-automerger
Copy link

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

  • Trying to change EIP 1153 state from Last Call to Final
  • Trying to change EIP 7516 state from Last Call to Final
  • Trying to change EIP 7568 state from Last Call to Final

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-review Waiting on author to review c-status Changes a proposal's status s-final This EIP is Final t-core t-meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants