-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn EIPs repository into a Github Pages / Jekyll site #940
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff!
The link to the preview generated site, http://arachnid.github.io/EIPs/, gives a 404. Other than that this looks good! |
@jamesray1 Should be fixed now, though I'll take it down again once it's up and running on its permanent URL. |
Excellent. Categorize this as an Ethereum Improvement Proposal that helps everyone better understand what's going on. |
@Arachnid awesome, the preview looks great! |
Oh, the link to the template EIP doesn't work. |
It needs to have .md on the end of it; this works: |
@jamesray1 Fixed in my outstanding PR, thanks for spotting it. |
You're welcome Nick! |
This PR restructures the EIPs repository so merged EIPs can be parsed as Jekyll documents, and adds structure and configuration to render it as such. A preview of the generated site can be seen here.
Changes to the already-committed EIPs:
In addition, this PR includes a few changes to EIP-1:
The template eip-X has also been updated to reflect these changes.
Next steps (after this PR):