-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ERC-6909: Move to Review #146
Conversation
File
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Your abstract is a bit too terse. It should include a high-level technical description of how it solves the problem. In this case, maybe you could include a few sentences describing what it removes/adds compared to ERC-1155?
- The interface ID shouldn't be in the rationale section. It belongs in the Specification section.
- Same goes for the metadata extension. Since you're introducing new functionality, and not just explaining the reasoning behind your specification, it has to go in the specification section.
…nto jtriley-eth/to-review
diff isn't showing bc i merged a different branch into main first, but recommended fixes are done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have a "SHOULD NOT" and a "MAY" requirement in your rationale section. All requirements should be in the specification section.
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
No description provided.