Update ERC-6596: Move to Review #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 31, 2023
dhl
force-pushed
the
update_erc-6596_r1
branch
from
77c3168 to
545533f
Compare
|
✅ All reviewers have approved. |
eip-review-bot
changed the title
|
Rebased changes onto main to pick up validation fixes. |
SamWilsn
reviewed
Nov 14, 2023
|
Appreciate the thoughtful comments, @SamWilsn. We are addressing your comments in a new update. Thanks for taking the time to review this ERC! |
|
The commit b307308 (as a parent of 80ed930) contains errors. |
dhl
force-pushed
the
update_erc-6596_r1
branch
from
ad64733 to
3af0213
Compare
dhl
force-pushed
the
update_erc-6596_r1
branch
from
3af0213 to
53c6f8d
Compare
dhl
force-pushed
the
update_erc-6596_r1
branch
from
53c6f8d to
2a0c3a6
Compare
19 tasks
SamWilsn
approved these changes
Nov 28, 2023
eip-review-bot
approved these changes
Nov 28, 2023
eip-review-bot
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've updated the specification of the previous proposal based on feedback from museums and galleries we spoke with.
While the spec has been simplified and made to work better with the existing NFT ecosystem, the spirit of the specification remains the same.
We now feel ready to push the ERC to the review state.
PR migrated from ethereum/EIPs#7861 per the instruction of @SamWilsn (thanks Sam!)