Charge for hashing init code in CREATE2

[gumb0]

Changing the gas cost of CREATE2 according to the latest changes in spec ethereum/EIPs#1375

cc @winsvega

[codecov-io]

Codecov Report

Merging #5295 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #5295      +/-   ##
=========================================
+ Coverage   61.09%   61.1%   +0.01%     
=========================================
  Files         340     340              
  Lines       27764   27784      +20     
  Branches     3208    3209       +1     
=========================================
+ Hits        16962   16977      +15     
- Misses       9668    9673       +5     
  Partials     1134    1134

[gumb0]

@chfast Any idea what happened to macOS build here?

[chfast]

It cannot find sha3WordGas symbol :/

[gumb0]

Linker can't find the symbol, but it's constexpr, weird. And it's fine with VMSchedule::createGas in the same function 😕

[chfast]

Write it as u512(initSize) because there is not data loss here.

[gumb0]

I prefer to avoid C-style casts altogether, than to have a rule when they're safe
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Res-casts-named

But here u512{initSize} can be used, I'll change it.

[gumb0]

@chfast Looks like it's obscure C++11 & 14 rules about static constexpr, fixed in C++17
https://stackoverflow.com/questions/40690260/undefined-reference-error-for-static-constexpr-member

[gumb0]

So uint64_t{VMSchedule::sha3WordGas} fixes the linker error.

Another option is to add definitions of VMSchedule static members to cpp file like

constexpr int64_t VMSchedule::sha3WordGas;
...

https://en.cppreference.com/w/cpp/language/static#Constant_static_members

[chfast]

I don't care which workaround is used, but I've found this for SHA3 instructions:

        CASE(SHA3)
        {
            ON_OP();
            constexpr int64_t sha3Gas = VMSchedule::sha3Gas;
            constexpr int64_t sha3WordGas = VMSchedule::sha3WordGas;
            m_runGas = toInt63(sha3Gas + (u512(m_SP[1]) + 31) / 32 * sha3WordGas);

[gumb0]

I see, this is third kind of workaround.

So as I understand constexpr int64_t sha3WordGas = VMSchedule::sha3WordGas; works and (u512(m_SP[1]) + 31) / 32 * VMSchedule::sha3WordGas doesn't, because the second one probably tries to pass VMSchedule::sha3WordGas by reference to boost::multiprecision::operator* and creating a reference requires definition outside of class in C++11

[chfast]

I don't know why it work and I don't want to know. I think it was me who add this but I have not investigated the reasons.

[chfast]

Also maybe squash commits?

[chfast]

Same static_cast -> u512{} change here.

[gumb0]

done