Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capella state definition missing historical_summaries #315

Closed
rolfyone opened this issue May 2, 2023 · 0 comments · Fixed by #316
Closed

Capella state definition missing historical_summaries #315

rolfyone opened this issue May 2, 2023 · 0 comments · Fixed by #316

Comments

@rolfyone
Copy link
Contributor

rolfyone commented May 2, 2023

https://github.com/ethereum/consensus-specs/blob/dev/specs/capella/beacon-chain.md#beaconstate

A late change to capella, was the retiring of historical_roots, and switch to historical_summaries.

We will need to make this change in capella, and deneb if it's merged. Identified in #289 review.
rolfyone added a commit to rolfyone/beacon-APIs that referenced this issue May 2, 2023
@rolfyone
Added historical summaries to Capella beacon state.
b82dd7f 
In Capella, historical_roots has been replaced by historical_summaries, but this was not reflected in our state object.

Fixes ethereum#315
@rolfyone rolfyone mentioned this issue May 2, 2023
Merged
rolfyone added a commit that referenced this issue May 2, 2023
@rolfyone
Added historical summaries to Capella beacon state. (#316)
ec5f935 
In Capella, historical_roots has been replaced by historical_summaries, but this was not reflected in our state object.

Fixes #315
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added historical summaries to Capella beacon state. rolfyone/beacon-APIs
1 participant
@rolfyone