Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HTTP 414 status code for GET maxItems enforcement #329

Merged
merged 3 commits into from
Jun 21, 2023

Conversation

jshufro
Copy link
Contributor

@jshufro jshufro commented Jun 16, 2023

I'd like to make the case for why these codes should be implemented-

  1. The 400 description doesn't mention maxItems: Invalid state or validator ID, so a BN enforcing maxItems will potentially confuse a downstream system.
  2. The BN isn't always directly responsible for responding to the downstream system- for example, nginx, cloudflare, haproxy, etc may return a 414 if the Request-Line is too long. Enshrining the 414 code in the spec serves as a signal to programmers of downstream systems that they ought to take care to handle those errors.
  3. A client team developing both a VC and a BN may incorrectly assume that because their BN never returns a 414, they do not need to handle a 414 in the VC.

Copy link
Collaborator

@rolfyone rolfyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rolfyone rolfyone merged commit e46bd0c into ethereum:master Jun 21, 2023
@Falehfale Falehfale mentioned this pull request Sep 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants