-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add blob_sidecar event #350
Conversation
Rationale behind including the KZG commitment is that https://github.com/ethereum/consensus-specs/blob/dev/specs/deneb/beacon-chain.md#beaconblockbody only contains the commitment. So if (for example) you received a Not sure about how useful this would be in the real world, but the commitment is the only way that I can see to link blobs to consensus blocks (beyond the obvious other information already in the event). I would include the versioned hash as well, as that provides a similar function for the execution layer. |
casting my vote for blob_sidecar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just needs to be added to the change list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Discussion points
blob
orblob_sidecar
. There won't be two different types of blob events soblob
is shorter. Butblob_sidecar
matches the returned container summary.kzg_commitment_to_versioned_hash
Closes #348