Add new rules on block scoring excluding withdrawals #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
approved these changes
Feb 27, 2024
twoeths
reviewed
Feb 28, 2024
| `pre_state_balance` is the ether amount at the `fee_recipient`’s address in the execution state before applying | ||
| the `execution_payload` and the `post_state_balance` is the same data after applying the `execution_payload`. | ||
|
|
||
| Any block submissions where `verify_bid_value` fails should be considered invalid and **MUST** not be served to proposers requesting bids. |
There was a problem hiding this comment.
is this verify_bid_value executed in consensus layer or execution layer? consensus layer has no information about fee_recipient balance at pre_execution_state and post_execution_state
There was a problem hiding this comment.
relays would verify this value as part of confirming execution validity
they have the withdrawals from the CL and can check the balance against the EL
metachris
reviewed
Feb 28, 2024
metachris
reviewed
Feb 28, 2024
| assert proposer_payment == bid_value | ||
| ``` | ||
|
|
||
| `verify_bid_value` should execute completely, noting that assertion failures are errors. |
There was a problem hiding this comment.
should these be bullets?
There was a problem hiding this comment.
I think its fine without
Co-authored-by: Jacob Kaufmann <[email protected]>
Co-authored-by: Chris Hager <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements mev-boost improvement proposal #0.