Make FIELD_ELEMENTS_PER_BLOB compile-time configurable #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrchz
force-pushed
the
configure_blob_size
branch
from
f8542f2 to
070948d
Compare
|
Is it possible as part of this PR a version of https://github.com/ethereum/c-kzg-4844/blob/main/src/trusted_setup.txt to be included which will work when FIELD_ELEMENTS_PER_BLOB is set to 4 |
|
If you have one handy I'm happy to add it :) |
I actually couldn't make one work, was getting C_KZG_BADARGS. I was trying to adapt the one from the consensus specs https://github.com/ethereum/consensus-specs/blob/dev/presets/minimal/trusted_setups/testing_trusted_setups.json |
|
Thanks for suggesting this - it uncovered some bugs in the PR. |
dgcoffman
reviewed
Dec 2, 2022
belijzajac
added a commit
to grandinetech/rust-kzg
that referenced
this pull request
Dec 11, 2022
We have to use the makefile to build the library; see ethereum/c-kzg-4844#16
sauliusgrigaitis
added a commit
to grandinetech/rust-kzg
that referenced
this pull request
Dec 11, 2022
* Updated Rust version * Fix `c-kzg-4844` build We have to use the makefile to build the library; see ethereum/c-kzg-4844#16 * Fix clippy Co-authored-by: belijzajac <[email protected]>
sauliusgrigaitis
added a commit
to grandinetech/rust-kzg
that referenced
this pull request
Dec 18, 2022
* Updated Rust version * Fix clippy * Fix clippy * Fix `c-kzg-4844` build We have to use the makefile to build the library; see ethereum/c-kzg-4844#16 * Fix clippy Co-authored-by: belijzajac <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.