-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nodejs bindings to use runtime field count #366
Update nodejs bindings to use runtime field count #366
Conversation
@matthewkeil would be great if you could take a look here. Thanks! |
Co-authored-by: George Kadianakis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Matthew Keil <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! 🚀
Would love to actually run the tests to make sure all is well once #352 is approved and merged.
Great. Yes, we'll be sure that all of the tests pass before merging! |
I'm slightly confused on why the bindings here use Is this mixed usage of |
Co-authored-by: George Kadianakis <[email protected]>
For the API, I think
For me, yeah. As long as it's I suppose I don't know what the alternative is in the C++ code. Would you prefer we |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks all!
This PR updates the Node.js bindings to work with runtime field counts.
Note: the JSON trusted setup was outdated. It contained 4096 G2 points. Pulled in the latest version.