Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid sanity test block state root #1146

Closed
sorpaas opened this issue Jun 7, 2019 · 5 comments
Closed

Invalid sanity test block state root #1146

sorpaas opened this issue Jun 7, 2019 · 5 comments
Labels
scope:CI/tests/pyspec

Comments

@sorpaas
Copy link

sorpaas commented Jun 7, 2019

For blocks sanity test. Block state root is always zero, which makes it fail the final state root check required in the spec.
@sorpaas sorpaas mentioned this issue Jun 7, 2019
Merged
@JustinDrake
Copy link
Contributor

I'm sorry, I don't understand the issue. Would you mind expanding?

@sorpaas
Copy link
Author

sorpaas commented Jun 10, 2019

@JustinDrake blocks provided in the sanity test have its block state root field set to ZERO_HASH, but that’s clearly a wrong value.

@djrtwo
Copy link
Contributor

djrtwo commented Jun 13, 2019

looking into this

@protolambda
Copy link
Contributor

Possible solution for tests:

  • transition up to some testing scenario (optional)
  • sign block
  • output pre
  • transition block, verify-state-root is off
  • update block state root
  • sign block again
  • output block
  • output post

@djrtwo djrtwo mentioned this issue Jun 13, 2019
Merged
djrtwo added a commit that referenced this issue Jun 13, 2019
@djrtwo
address #1146 by inserting state root and re-signing blocks in tests
c391017
@djrtwo djrtwo mentioned this issue Jun 14, 2019
Merged
protolambda added a commit that referenced this issue Jun 14, 2019
@protolambda
Merge pull request #1177 from ethereum/block-state-root-fix
7cf0dcd 
Fix #1146 block state root issue
@djrtwo
Copy link
Contributor

djrtwo commented Jun 14, 2019

addressed in #1177.
to be released in v0.7.1

@djrtwo djrtwo closed this as completed Jun 14, 2019
@sorpaas sorpaas mentioned this issue Jun 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scope:CI/tests/pyspec
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@JustinDrake @djrtwo @sorpaas @hwwhww @protolambda