Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add back in active_index_roots #1247

Merged
merged 2 commits into from
Jul 1, 2019
Merged

add back in active_index_roots #1247

merged 2 commits into from
Jul 1, 2019

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented Jun 30, 2019 •
edited
Loading

As discussed with @vbuterin and @JustinDrake, we are calculating active_index_root when calculating committees_root so might as well cache it in state

Note: this also cut our test time down

@djrtwo djrtwo requested a review from CarlBeek June 30, 2019 20:25
@JustinDrake JustinDrake added the milestone:June 30 freeze 🥶 Phase 0 spec freeze for long-lived cross-client testnet label Jun 30, 2019
CarlBeek
CarlBeek approved these changes Jun 30, 2019
View reviewed changes
Copy link
Contributor

@CarlBeek CarlBeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conceptually, I like it. :) Caching an extra Hash in state saves a lot of compute and reflects how clients will likely cache it anyway. Code LGTM too.

@djrtwo djrtwo requested a review from JustinDrake June 30, 2019 20:58
@djrtwo djrtwo merged commit 2ab55bf into dev Jul 1, 2019
@djrtwo djrtwo deleted the add-active-index-roots-back branch July 1, 2019 01:23
@terencechain terencechain mentioned this pull request Jul 1, 2019
Closed
19 tasks
@nisdas nisdas mentioned this pull request Jul 2, 2019
Merged
3 tasks
@hwwhww hwwhww mentioned this pull request Jul 5, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlBeek CarlBeek CarlBeek approved these changes

@JustinDrake JustinDrake JustinDrake approved these changes

Assignees
No one assigned
Labels
milestone:June 30 freeze 🥶 Phase 0 spec freeze for long-lived cross-client testnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djrtwo @JustinDrake @CarlBeek