Fix period tail in get_eth1_vote #1468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cleanup of
get_eth1_voteinspired by @paulhauner's PR #1463 and subsequent conversation.The previous version was incorrectly assuming that there was an
eth1_data_voteper slot, but this is not the case when 100% of proposers don't get blocks into the chain. Instead the period tail should be based upon the actual slot.This PR simplifies the logic so that in the early slots of a voting period, you only consider
new_eth1_datawhen deciding your vote, but in the period tail to encourage settling on a vote, you considerall_eth1_data.