De-duplicate range references in BlobSidecarsByRange #3162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djrtwo
reviewed
Jan 1, 2023
There was a problem hiding this comment.
slightly prefer definitely it with a variable -- e.g. "Let blobs_serve_range be [max(GENESIS_EPOCH, current_epoch - MIN_EPOCHS_FOR_BLOBS_SIDECARS_REQUESTS), current_epoch]" above all three statements and then just reference as "the range blobs_serve_range"
Not a strong opinion here though
hwwhww
force-pushed
the
eip4844-dedup-range
branch
from
a924b5b to
0eda0cc
Compare
dapplion
force-pushed
the
eip4844-dedup-range
branch
from
0eda0cc to
939ebe6
Compare
dapplion
changed the title
dapplion
force-pushed
the
eip4844-dedup-range
branch
2 times, most recently
from
599c1a6 to
c01409b
Compare
dapplion
force-pushed
the
eip4844-dedup-range
branch
from
c01409b to
21cf61e
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference unique range definition to prevent specifying it multiple times. No strong opinion here, happy to stick to current dev if language is clearer