Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Capella fork version for BLSToExecution #3176

Closed
wants to merge 3 commits into from
Closed

Use Capella fork version for BLSToExecution #3176

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b15581a
Use Capella fork version for BLSToExecution
mkalinin Dec 23, 2022
cd7d2ce
Update specs/capella/p2p-interface.md
mkalinin Jan 9, 2023
f41f2f7
Update p2p-interface.md
mkalinin Jan 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion specs/capella/p2p-interface.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,16 @@ See Capella [state transition document](./beacon-chain.md#beaconblockbody) for f

This topic is used to propagate signed bls to execution change messages to be included in future blocks.

Let `head_state` be a post state of the head of canonical chain.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the chain or including any empty transitions to get to the current slot wrt wall time?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I think we don't need the whole state in the definition of this change. I'll switch to system_clock_epoch (Thought this name for the variable would be less ambiguous than current_epoch)

The following validations MUST pass before forwarding the `signed_bls_to_execution_change` on the network:

- _[IGNORE]_ The `signed_bls_to_execution_change` is the first valid signed bls to execution change received
for the validator with index `signed_bls_to_execution_change.message.validator_index`.
- _[REJECT]_ All of the conditions within `process_bls_to_execution_change` pass validation.
- If `get_current_epoch(head_state) < CAPELLA_FORK_EPOCH`:
- _[REJECT]_ All of the conditions within `process_bls_to_execution_change` pass validation
using `head_state.fork.current_version` in signing domain computation.
mkalinin marked this conversation as resolved.
Show resolved Hide resolved
- If `get_current_epoch(head_state) >= CAPELLA_FORK_EPOCH`:
- _[REJECT]_ All of the conditions within `process_bls_to_execution_change` pass validation.

### Transitioning the gossip

Expand Down