Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and move test_multiple_consolidations_* tests to sanity block tests #3724

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Fix and move test_multiple_consolidations_* tests to sanity block tests #3724

merged 1 commit into from
Apr 25, 2024

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Apr 25, 2024 •
edited
Loading

Fix #3723

Move the test_multiple_consolidations_* tests to sanity block tests. Since MAX_CONSOLIDATIONS is 1, I added each consolidation to a block.

/cc @fradamt

@hwwhww hwwhww requested a review from ralexstokes April 25, 2024 15:37
ralexstokes
ralexstokes approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yeah, these tests didn't conform to the format they were written for

I think moving them to sanity blocks tests makes the most sense

@hwwhww hwwhww merged commit e5ba8bc into dev Apr 25, 2024
28 checks passed
@hwwhww hwwhww deleted the fix-multiple_consolidations-tests branch April 25, 2024 16:10
@hwwhww hwwhww mentioned this pull request Apr 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralexstokes ralexstokes ralexstokes approved these changes

Assignees
No one assigned
Labels
scope:CI/tests/pyspec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wrong consolidation operations test vector output
2 participants
@hwwhww @ralexstokes