Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-7594: Replace "proofs" with "kzg_proofs" in function names #3727

Merged
merged 3 commits into from
Apr 26, 2024

Conversation

jtraglia
Copy link
Member

@jtraglia jtraglia commented Apr 25, 2024

We should rename these for consistency with the EIP-4844 functions, e.g.:

  • compute_kzg_proof
  • verify_blob_kzg_proof
  • verify_blob_kzg_proof_batch

@jtraglia jtraglia added the EIP-7594 PeerDAS label Apr 25, 2024
@jtraglia jtraglia changed the title Rename verify_cell_proof* to verify_cell_kzg_proof* EIP-7594: Replace "proofs" with "kzg_proofs" in function names Apr 26, 2024
@hwwhww hwwhww mentioned this pull request Apr 26, 2024
4 tasks
Copy link
Contributor

@asn-d6 asn-d6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@asn-d6 asn-d6 merged commit b5f22cd into ethereum:dev Apr 26, 2024
28 checks passed
@jtraglia jtraglia deleted the rename-verify-cell-proof branch April 26, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EIP-7594 PeerDAS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants