Fix get_custody_columns
#3748
Merged
Fix get_custody_columns
#3748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 6, 2024
Merged
ralexstokes
approved these changes
May 6, 2024
zilm13
reviewed
May 7, 2024
specs/_features/eip7594/das-core.md
Outdated
| if node_id == UINT256_MAX: | ||
| node_id = NodeID(0) | ||
| # Overflow prevention | ||
| if tmp_id == UINT256_MAX: |
Co-authored-by: Alex Stokes <[email protected]>
hwwhww
commented
May 7, 2024
specs/_features/eip7594/das-core.md
Outdated
| @@ -106,18 +106,20 @@ def get_custody_columns(node_id: NodeID, custody_subnet_count: uint64) -> Sequen | |||
| assert custody_subnet_count <= DATA_COLUMN_SIDECAR_SUBNET_COUNT | |||
|
|
|||
| subnet_ids: List[uint64] = [] | |||
| i = 0 | |||
| i = uint256(node_id) | |||
There was a problem hiding this comment.
Ah sorry @ralexstokes I think I have the revert the previous commit. There is another i usage in the return sorted(...)... so it's less good to assign an i here.
hwwhww
force-pushed
the
fix-get_custody_columns
branch
from
b256bba to
c9e0e6d
Compare
wailin247
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace #3742
Thank @nalepae for raising the issue, and thank @zilm13 for proposing a fix for the bug. 🙏