Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add electra version of AggregateAndProof #3759

Merged
merged 5 commits into from
May 8, 2024
Merged

Add electra version of AggregateAndProof #3759

merged 5 commits into from
May 8, 2024

Conversation

jtraglia
Copy link
Member

@jtraglia jtraglia commented May 7, 2024

For Electra, we need to extend AggregateAndProof (and SignedAggregateAndProof) to use the new Attestation type.

@jtraglia jtraglia requested review from ralexstokes and hwwhww May 7, 2024 21:34
ralexstokes
ralexstokes reviewed May 7, 2024
View reviewed changes
Copy link
Member

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

for consistency, I'd prefer these in the electra/validator.md file

e.g. https://github.com/ethereum/consensus-specs/blob/dev/specs/phase0/validator.md#aggregateandproof

hwwhww
hwwhww approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@hwwhww hwwhww merged commit 812ac2c into ethereum:dev May 8, 2024
26 checks passed
@jtraglia jtraglia deleted the ext-aggregate-and-proof branch May 8, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralexstokes ralexstokes ralexstokes left review comments

@hwwhww hwwhww hwwhww approved these changes

Assignees
No one assigned
Labels
Electra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtraglia @ralexstokes @hwwhww