EIP-7594: clarifying reconstruction and cross-seeding #3794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- when should a node reconstruct - how to cross-seed for subscribed and unsubscribed topics Signed-off-by: Csaba Kiraly <[email protected]>
cskiraly
changed the title
|
@hwwhww , I have created this PR to improve the description of on-the-fly repair and related cross-seeding based on what we've discussed during the interop. I hope it maps well to the ideas that emerged. can you label this with eip-7594? Thanks! |
fradamt
reviewed
Jun 14, 2024
Signed-off-by: Csaba Kiraly <[email protected]>
nisdas
approved these changes
Jun 25, 2024
dapplion
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to clarify rules and recommendations for on-the-fly reconstruction and cross-seeding:
Notes: For unsubscribed topics, we are not seeding to avoid potentially gererating too many duplicates. If, however, we want to speed up spread in this case, it might make sense to send it to a limited number (e.g. 1) of fanout peers, or to immediately generate IHAVE messages without waiting for the heartbeat.