Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spec error in get_generalized_index function #3838

Merged
merged 1 commit into from
Aug 3, 2024
Merged

Fix spec error in get_generalized_index function #3838

merged 1 commit into from
Aug 3, 2024

Conversation

kocubinski
Copy link
Contributor

As written assert will always fail since typ was just set to uint64.

@itsdevbear itsdevbear mentioned this pull request Jul 9, 2024
Closed
ralexstokes
ralexstokes approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! nice catch

jtraglia
jtraglia approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, nice catch. Thanks!

@hwwhww hwwhww merged commit 1a086f6 into ethereum:dev Aug 3, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtraglia jtraglia jtraglia approved these changes

@hwwhww hwwhww hwwhww approved these changes

@ralexstokes ralexstokes ralexstokes approved these changes

Assignees
No one assigned
Labels
scope:CI/tests/pyspec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kocubinski @ralexstokes @hwwhww @jtraglia