Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Deneb on_block tests in Electra but not 7594 #3883

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

potuz
Copy link
Contributor

@potuz potuz commented Aug 14, 2024

In #3870 a change was made to skip Deneb tests in the Electra fork. This PR restores the previous behavior but skips the tests if the EIP-7594 fork is activated.

@potuz potuz force-pushed the run_deneb_tests_in_electra branch from 29f38ae to 2bfb6ab Compare August 14, 2024 13:01
@potuz potuz force-pushed the run_deneb_tests_in_electra branch from 2bfb6ab to d10cc00 Compare August 14, 2024 13:03
@jtraglia jtraglia requested a review from fradamt August 14, 2024 16:29
Copy link
Member

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me. Thanks!

Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @potuz!

@hwwhww hwwhww merged commit 5c44de2 into ethereum:dev Aug 20, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants